Fix install destinations #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.` will by default install to `/usr/local/./armips` (similar for the Readme) which is undesirable. armips should install to a bin directory, Readme should install to a doc directory for the executable.
|
Hm, I'm not sure if these would be ideal for Windows packages. What do you think of using GNUInstallDirs and overriding the variables with suitable paths when on Windows? That'd give maximum flexibility too. |
|
I can certainly look into it, though I'm not familiar with when you'd ever use |
|
How are these even used on Windows considering Windows has neither |
Use default UNIX values on non-Windows systems, use the prefix directory itself on Windows.
|
Windows is untested, but should work the same as it did previously. |
Previous commit feels over-engineered.
|
Can this PR be merged? I feel confusing too when the bin is installed in /usr/local, which is not in the PATH. |
|
+1 To this, please :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.will by default install to/usr/local/./armips(similar for the Readme) which is undesirable. armips should install to a bin directory, Readme should install to a doc directory for the executable.